Variable length arithmetic #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @JasperTey. I am currently focused on my talk on Laracon EU next week. I max make some changes to your PR and merge it when coming back. |
|
Thanks for your contribution. Its now released as I've made some small improvements:
|
Fantastic, thanks for refining further. I saw you add support for
|
|
Youre right. Completely forgot updating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Add,Subtract,Multiply,DivideandModulonow accept variable number of additional arguments beyond the first twoThis PR implements support for variable-length arithmetic arguments where applicable, as discussed in #23.
I didn't end up applying this update to the bitwise operations even though it was initially deemed mathematically possible, for two reasons:
(({$value1} | {$value2}) - ({$value1} & {$value2})); and I didn't want to go there for this PR.I'm open to alternate naming conventions and/or testing methodology.